HomePhabricator

Generalize Legalpad validation logic for "Require Signature"

Description

Generalize Legalpad validation logic for "Require Signature"

Summary:
See downstream https://phabricator.wikimedia.org/T208254.

I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code.

Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value.

Test Plan:
Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required.

Couldn't reproduce the original issue, but this version is generally more correct/robust.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20311

Details

Provenance
epriestleyAuthored on Mar 22 2019, 4:22 PM
epriestleyPushed on Mar 25 2019, 6:26 PM
Reviewer
amckinley
Differential Revision
D20311: Generalize Legalpad validation logic for "Require Signature"
Parents
rPe15b3dd3c610: When a repository is inactive, mark its handle as "closed"
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22356
Build 30587: Run Core Tests