HomePhabricator

Allow Herald to add package reviewers

Tags
None
Referenced Files
F1311731: Screen Shot 2016-05-13 at 11.33.53 AM.png
May 14 2016, 12:23 AM
F1311733: Screen Shot 2016-05-13 at 11.32.56 AM.png
May 14 2016, 12:23 AM
F1311732: Screen Shot 2016-05-13 at 11.33.46 AM.png
May 14 2016, 12:23 AM
Subscribers
None

Description

Allow Herald to add package reviewers

Summary: Ref T10939. Packages are valid reviewers, so let Herald "Add Reviewers" and "Add Blocking Reviewers" actions add them.

Test Plan:

  • Wrote a rule to add package reviewers.
  • Hit the rule, saw a package reviewer added, viewed transcript.

Screen Shot 2016-05-13 at 11.33.53 AM.png (177×510 px, 30 KB)

Screen Shot 2016-05-13 at 11.33.46 AM.png (176×700 px, 30 KB)

Screen Shot 2016-05-13 at 11.32.56 AM.png (1×1 px, 162 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15917

Details

Provenance
epriestleyAuthored on May 13 2016, 6:31 PM
epriestleyPushed on May 14 2016, 12:23 AM
Reviewer
chad
Differential Revision
D15917: Allow Herald to add package reviewers
Parents
rP332d787dc8f4: Support "Review Changes" and "Block Changes" settings for Owners package…
Branches
Unknown
Tags
Unknown
Tasks
T10939: Support for OWNERS files
Build Status
Buildable 12207
Build 15412: Run Core Tests