Page MenuHomePhabricator

Allow Herald to add package reviewers
ClosedPublic

Authored by epriestley on May 13 2016, 6:35 PM.

Details

Summary

Ref T10939. Packages are valid reviewers, so let Herald "Add Reviewers" and "Add Blocking Reviewers" actions add them.

Test Plan
  • Wrote a rule to add package reviewers.
  • Hit the rule, saw a package reviewer added, viewed transcript.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 38321.May 13 2016, 6:35 PM
epriestley retitled this revision from to Allow Herald to add package reviewers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.May 13 2016, 7:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:49 PM
This revision was automatically updated to reflect the committed changes.