Make repository URI creation work regardless of "repository" transaction order
921d56efb0f0
Actions

Description

Make repository URI creation work regardless of "repository" transaction order

Summary: Fixes T11276. This feels slightly iffy (we attachRepository() here, and also when applying the TYPE_REPOSITORY transaction) but simpler than trying to reorder things.

Test Plan: Created a repository URI with transactions in ["uri", "repository"] order.

Reviewers: chad, avivey

Reviewed By: avivey

Maniphest Tasks: T11276

Differential Revision: https://secure.phabricator.com/D16237

Details

Provenance

epriestley	Authored on Jul 5 2016, 11:38 PM
epriestley	Pushed on Jul 5 2016, 11:45 PM

Reviewer

avivey

Differential Revision

D16237: Make repository URI creation work regardless of "repository" transaction order

Parents

rP5ffdb732735c: Don't try to prune unreachable commits from repositories with no outdated refs

Branches

Unknown

Tags

Unknown

Tasks

T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input

Build Status

Buildable 12936
Build 16509: Run Core Tests

Event Timeline

epriestley committed rP921d56efb0f0: Make repository URI creation work regardless of "repository" transaction order (authored by epriestley).Jul 5 2016, 11:45 PM

epriestley added a task: T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.

Harbormaster completed building B12936: rP921d56efb0f0: Make repository URI creation work regardless of "repository" transaction order.Jul 5 2016, 11:46 PM

Changes (1)

Path

Size

src/

applications/

diffusion/

editor/

DiffusionURIEditor.php

rP921d56efb0f0

View Options

src/applications/diffusion/editor/DiffusionURIEditor.php