Page MenuHomePhabricator

Make repository URI creation work regardless of "repository" transaction order
ClosedPublic

Authored by epriestley on Jul 5 2016, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 10:33 AM
Unknown Object (File)
Mon, Mar 18, 2:55 AM
Unknown Object (File)
Mon, Mar 4, 9:03 PM
Unknown Object (File)
Feb 22 2024, 5:56 AM
Unknown Object (File)
Feb 15 2024, 7:59 AM
Unknown Object (File)
Jan 24 2024, 9:19 PM
Unknown Object (File)
Jan 17 2024, 9:44 PM
Unknown Object (File)
Dec 29 2023, 3:17 PM
Subscribers
None

Details

Summary

Fixes T11276. This feels slightly iffy (we attachRepository() here, and also when applying the TYPE_REPOSITORY transaction) but simpler than trying to reorder things.

Test Plan

Created a repository URI with transactions in ["uri", "repository"] order.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make repository URI creation work regardless of "repository" transaction order.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
src/applications/diffusion/editor/DiffusionURIEditor.php
126

When processing in the other order, we run this part first so the code works.

avivey edited edge metadata.

probably fine

This revision is now accepted and ready to land.Jul 5 2016, 11:44 PM
This revision was automatically updated to reflect the committed changes.