HomePhabricator

Update Settings to use full side-navigation

Authored by Chad Little <chad@phacility.com> on Aug 4 2017, 5:16 PM.

Description

Update Settings to use full side-navigation

Summary: Moves Settings to use a normal side navigation vs. a two column side navigation. It also updates Edit Engine to do the same, but I don't think there are other callsites. Added a consistent header for better clarification if you were editng your settings, global settings, or a bot's settings.

Test Plan: Test each page on a personal account, create global settings, test each page there, create a bot account, and test each page on the bot account. Anything else?

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D18342

Details

Committed
Chad Little <chad@phacility.com>Aug 4 2017, 5:23 PM
Pushed
chadAug 4 2017, 5:23 PM
Reviewer
epriestley
Differential Revision
D18342: Update Settings to use full side-navigation
Parents
rP68ab9b2642b8: Switch fluid to fixed on PHUITwoColumnView
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17911
Build 24055: Run Core Tests