HomePhabricator

(stable) Handle tag tags properly in discovery

Description

(stable) Handle tag tags properly in discovery

Summary:
Fixes T11180. In Git, it's possible to tag a tag (????). When you do, we try to log the tag-object, which automatically resolves to the commit and fails.

Just skip these. If "A" points at "B" which points at "C", it's fine to ignore "A" and "B" since we'll get the same stuff when we process "C".

Test Plan:

  • Tagged a tag.
  • Pushed it.
  • Discovered it.
  • Before patch: got exception similar to the one in T11180.
  • After patch: got tag-tag skipped. Also got slightly better error messages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11180

Differential Revision: https://secure.phabricator.com/D16149

Details

Provenance
epriestleyAuthored on Jun 20 2016, 6:07 PM
epriestleyPushed on Jun 20 2016, 6:36 PM
Reviewer
chad
Differential Revision
D16149: Handle tag tags properly in discovery
Parents
rP59bc6adc0e22: (stable) Promote 2016 Week 25
Branches
Unknown
Tags
Unknown
Tasks
T11180: Daemons fail to discover when a repository contains tags which tag other tags
Build Status
Buildable 12736
Build 16199: Run Core Tests