Page MenuHomePhabricator

Handle tag tags properly in discovery
ClosedPublic

Authored by epriestley on Jun 20 2016, 6:08 PM.
Tags
None
Referenced Files
F14002865: D16149.id38853.diff
Fri, Oct 25, 11:16 PM
F14001979: D16149.id.diff
Fri, Oct 25, 1:50 PM
F14001641: D16149.diff
Fri, Oct 25, 10:34 AM
F13994127: D16149.id38853.diff
Wed, Oct 23, 4:01 AM
F13984763: D16149.diff
Sun, Oct 20, 3:48 PM
F13976917: D16149.id38853.diff
Oct 18 2024, 4:17 PM
F13976010: D16149.diff
Oct 18 2024, 12:32 PM
F13975873: D16149.id38853.diff
Oct 18 2024, 12:00 PM
Subscribers
None

Details

Summary

Fixes T11180. In Git, it's possible to tag a tag (????). When you do, we try to log the tag-object, which automatically resolves to the commit and fails.

Just skip these. If "A" points at "B" which points at "C", it's fine to ignore "A" and "B" since we'll get the same stuff when we process "C".

Test Plan
  • Tagged a tag.
  • Pushed it.
  • Discovered it.
  • Before patch: got exception similar to the one in T11180.
  • After patch: got tag-tag skipped. Also got slightly better error messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Handle tag tags properly in discovery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.