HomePhabricator

[Redesign] PhabricatorApplicationSearchResultView

Description

[Redesign] PhabricatorApplicationSearchResultView

Summary: Ref T8099. This adds a new class which all search engines return for layout. I thought about this a number of ways, and I think this is the cleanest path. Each Engine can return whatever UI bits they needs, and AppSearch or Dashboard picks and lays the bits out as needed. In the AppSearch case, interfaces like Notifications, Calendar, Legalpad all need more custom layouts. I think this also leaves a resonable path forward for NUX as well. Also, not sure I implemented the class correctly, but assume thats easy to fix?

Test Plan: Review and do a search in each application changed. Grep for all call sites.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13332

Details

Provenance
Chad Little <chad@phacility.com>Authored on
chadPushed on Jun 19 2015, 10:46 AM
Reviewer
epriestley
Differential Revision
D13332: [Redesign] PhabricatorApplicationSearchResultView
Parents
rP29ac80be5c7d: Merge branch 'master' into redesign-2015
Branches
Unknown
Tags
Unknown
Tasks
T8099: Mid-2015 Phabricator Redesign

Event Timeline

/src/applications/search/controller/PhabricatorApplicationSearchController.php
232

PHUIObjectItemListView does not have a getActions() method?

SearchEngine classes need to return a PhabricatorApplicationSearchResultView from renderResultList() now. See the changes in this commit for how to wrap, e.g., a PHUIObjectItemListView in a PhabricatorApplicationSearchResultView.