HomePhabricator

Make minor correctness and display improvements to pull logs

Description

Make minor correctness and display improvements to pull logs

Summary:
Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.

Test Plan: Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13046

Differential Revision: https://secure.phabricator.com/D18917

Details

Provenance
epriestleyAuthored on Jan 23 2018, 4:17 PM
epriestleyPushed on Jan 23 2018, 10:13 PM
Reviewer
amckinley
Differential Revision
D18917: Make minor correctness and display improvements to pull logs
Parents
rPa6fbde784c71: Modernize "PhabricatorRepositoryPushEventQuery"
Branches
Unknown
Tags
Unknown
Tasks
T13046: Surface repository pull logs in the web UI
Build Status
Buildable 19161
Build 25871: Run Core Tests