Page MenuHomePhabricator

Make minor correctness and display improvements to pull logs
ClosedPublic

Authored by epriestley on Jan 23 2018, 4:28 PM.
Tags
None
Referenced Files
F15561597: D18917.id45376.diff
Tue, Apr 29, 9:03 PM
F15546362: D18917.id.diff
Sat, Apr 26, 3:12 PM
F15537830: D18917.diff
Thu, Apr 24, 3:59 PM
F15477372: D18917.id45376.diff
Apr 7 2025, 1:58 PM
F15450735: D18917.id45348.diff
Mar 28 2025, 5:49 PM
F15432594: D18917.diff
Mar 24 2025, 6:40 PM
F15432402: D18917.diff
Mar 24 2025, 5:58 PM
F15423915: D18917.id45376.diff
Mar 22 2025, 7:24 PM
Subscribers
None

Details

Summary

Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.
Test Plan

Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable