Page MenuHomePhabricator

Make minor correctness and display improvements to pull logs
ClosedPublic

Authored by epriestley on Jan 23 2018, 4:28 PM.
Tags
None
Referenced Files
F18752458: D18917.id.diff
Sat, Oct 4, 3:18 PM
F18750256: D18917.id45376.diff
Sat, Oct 4, 7:07 AM
F18741838: D18917.diff
Thu, Oct 2, 4:19 PM
F18694812: D18917.id45348.diff
Sat, Sep 27, 4:34 AM
F18672347: D18917.diff
Thu, Sep 25, 7:21 AM
F18645537: D18917.id45376.diff
Fri, Sep 19, 8:00 AM
F18590879: D18917.diff
Fri, Sep 12, 7:28 AM
F18582479: D18917.id45348.diff
Thu, Sep 11, 8:30 AM
Subscribers
None

Details

Summary

Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.
Test Plan

Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable