Page MenuHomePhabricator

Make minor correctness and display improvements to pull logs
ClosedPublic

Authored by epriestley on Jan 23 2018, 4:28 PM.
Tags
None
Referenced Files
F19098318: D18917.diff
Thu, Dec 4, 4:29 PM
F18905546: D18917.id.diff
Nov 8 2025, 2:34 PM
F18819952: D18917.id.diff
Oct 22 2025, 11:24 AM
F18814658: D18917.diff
Oct 20 2025, 11:42 PM
F18805120: D18917.id45348.diff
Oct 18 2025, 1:54 PM
F18752458: D18917.id.diff
Oct 4 2025, 3:18 PM
F18750256: D18917.id45376.diff
Oct 4 2025, 7:07 AM
F18741838: D18917.diff
Oct 2 2025, 4:19 PM
Subscribers
None

Details

Summary

Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.
Test Plan

Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable