HomePhabricator

Only require view permissions for read-only Git LFS requests

Description

Only require view permissions for read-only Git LFS requests

Summary: Ref T7789. Implement proper detection for read-only requests. Previously, we assumed every request was read/write and required lots of permissions, but we don't need "Can Push" permission if you're only cloning/fetching/pulling.

Test Plan:

  • Set push policy to "no one".
  • Fetched, got clean data out of LFS.
  • Tried to push, got useful error.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T7789

Differential Revision: https://secure.phabricator.com/D15499

Details

Provenance
epriestleyAuthored on Mar 19 2016, 5:11 PM
epriestleyPushed on Mar 19 2016, 9:23 PM
Reviewer
chad
Differential Revision
D15499: Only require view permissions for read-only Git LFS requests
Parents
rPd5f9e49e29c1: Use PHUIStatusListView in Diffusion commit list
Branches
Unknown
Tags
Unknown
Tasks
T7789: Support Git Large File Storage
Build Status
Buildable 11225
Build 13935: Run Core Tests