Page MenuHomePhabricator

Only require view permissions for read-only Git LFS requests
ClosedPublic

Authored by epriestley on Mar 19 2016, 6:11 PM.

Details

Summary

Ref T7789. Implement proper detection for read-only requests. Previously, we assumed every request was read/write and required lots of permissions, but we don't need "Can Push" permission if you're only cloning/fetching/pulling.

Test Plan
  • Set push policy to "no one".
  • Fetched, got clean data out of LFS.
  • Tried to push, got useful error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Only require view permissions for read-only Git LFS requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley edited edge metadata.
  • Also do set_time_limit(0).
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2016, 9:22 PM
This revision was automatically updated to reflect the committed changes.