Diffusion Phabricator 69194fdaf510

Make marking comments as "Done" work cleanly on EditEngine
69194fdaf510
Actions

Description

Make marking comments as "Done" work cleanly on EditEngine

Summary: Ref T11114. Fixes T10323.

Test Plan:

Marked comments as done only: no warning about not leaving a comment.
Did nothing: warning about posting an empty comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114, T10323

Differential Revision: https://secure.phabricator.com/D17120

Details

Provenance

epriestley	Authored on Dec 31 2016, 5:57 PM
epriestley	Pushed on Dec 31 2016, 6:12 PM

Reviewer

chad

Differential Revision

D17120: Make marking comments as "Done" work cleanly on EditEngine

Parents

rPa4ba7daf9009: Add transitional support for mail tags to Differential on EditEngine

Branches

Unknown

Tags

Unknown

Tasks

T11114: Move Differential to EditEngine
T10323: "Action With No Effect" when marking inline comments as done

Build Status

Buildable 15065
Build 19769: Run Core Tests

Event Timeline

epriestley committed rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine (authored by epriestley).Dec 31 2016, 6:12 PM

epriestley added a task: T11114: Move Differential to EditEngine.

epriestley added a task: T10323: "Action With No Effect" when marking inline comments as done.

Harbormaster failed to build B15065: rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine!Dec 31 2016, 6:18 PM

Harbormaster completed building B15065: rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine.Dec 31 2016, 6:22 PM

Changes (2)

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

DifferentialTransactionEditor.php

rP69194fdaf510

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php