Make marking comments as "Done" work cleanly on EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 31 2016, 5:59 PM.

Tags

None

Referenced Files

	F15488585: D17120.diff
	Thu, Apr 10, 11:46 PM

	F15452683: D17120.id41177.diff
	Sat, Mar 29, 6:42 AM

	F15444857: D17120.id.diff
	Thu, Mar 27, 11:37 AM

	F15442133: D17120.diff
	Wed, Mar 26, 9:42 PM

	F15420077: D17120.id41177.diff
	Fri, Mar 21, 11:07 AM

	F15380341: D17120.id.diff
	Mar 14 2025, 2:37 AM

	F15344315: D17120.id41164.diff
	Mar 10 2025, 3:45 AM

	Unknown Object (File)
	Feb 17 2025, 10:06 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10323: "Action With No Effect" when marking inline comments as done
T11114: Move Differential to EditEngine

Commits

rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine

Summary

Ref T11114. Fixes T10323.

Test Plan

Marked comments as done only: no warning about not leaving a comment.
Did nothing: warning about posting an empty comment.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 31 2016, 5:59 PM

chad accepted this revision.Dec 31 2016, 6:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 31 2016, 6:00 PM

Closed by commit rP69194fdaf510: Make marking comments as "Done" work cleanly on EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2016, 6:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

25 lines

DifferentialTransactionEditor.php

18 lines

Diff 41177

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php