HomePhabricator

Fix deletion detection when updating based on ZIP

Description

Fix deletion detection when updating based on ZIP

Summary: When the code to update based on ZIP went to look up the child fragments, it explicitly used the paths provided in the ZIP. This meant that we could never detect omissions because there'd never be a scenario where a child fragment would return but not exist in the ZIP. To fix this, the query should be using withLeadingPath instead of withPaths.

Test Plan: Uploaded a ZIP that omitted a file and saw the deleteFile get called (by placing debugging output in the code).

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4205

Differential Revision: https://secure.phabricator.com/D7736

Details

Provenance
hach-queAuthored on Dec 8 2013, 8:48 PM
hach-quePushed on Dec 8 2013, 8:49 PM
Reviewer
epriestley
Differential Revision
D7736: Fix deletion detection when updating based on ZIP
Parents
rPacd5d5ae4a39: Correctly handle downloading ZIP with empty directories in Phragment
Branches
Unknown
Tags
Unknown

Event Timeline