HomePhabricator

Correctly handle downloading ZIP with empty directories in Phragment

Description

Correctly handle downloading ZIP with empty directories in Phragment

Summary: This logic causes an exception because getPHID() is called on a fragment that has no latest version. This fixes the code so that in this scenario, it returns an empty array (with no path to be added to the ZIP).

Test Plan: Downloaded the ZIP successfully after the patch was applied.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4205

Differential Revision: https://secure.phabricator.com/D7735

Details

Provenance
hach-queAuthored on Dec 8 2013, 1:15 AM
hach-quePushed on Dec 8 2013, 1:15 AM
Reviewer
epriestley
Differential Revision
D7735: Correctly handle downloading ZIP with empty directories in Phragment
Parents
rPc48cfb31bc76: Implement viewing versions and downloading patches in Phragment
Branches
Unknown
Tags
Unknown

Event Timeline