Page MenuHomePhabricator

Fix deletion detection when updating based on ZIP
ClosedPublic

Authored by hach-que on Dec 7 2013, 6:32 AM.
Tags
None
Referenced Files
F15560769: D7736.id.diff
Tue, Apr 29, 4:30 PM
F15557490: D7736.diff
Mon, Apr 28, 9:51 PM
F15521329: D7736.id17482.diff
Sun, Apr 20, 1:09 PM
F15455382: D7736.id17500.diff
Mar 30 2025, 12:03 AM
F15454372: D7736.id.diff
Mar 29 2025, 6:15 PM
F15451816: D7736.diff
Mar 28 2025, 11:59 PM
F15440325: D7736.id17500.diff
Mar 26 2025, 12:08 PM
F15429713: D7736.id17482.diff
Mar 24 2025, 3:49 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4205: Implement Phragment
Commits
Restricted Diffusion Commit
rP67b37a5c1dc0: Fix deletion detection when updating based on ZIP
Summary

When the code to update based on ZIP went to look up the child fragments, it explicitly used the paths provided in the ZIP. This meant that we could never detect omissions because there'd never be a scenario where a child fragment would return but not exist in the ZIP. To fix this, the query should be using withLeadingPath instead of withPaths.

Test Plan

Uploaded a ZIP that omitted a file and saw the deleteFile get called (by placing debugging output in the code).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped