Page MenuHomePhabricator

Fix deletion detection when updating based on ZIP
ClosedPublic

Authored by hach-que on Dec 7 2013, 6:32 AM.
Tags
None
Referenced Files
F18091605: D7736.id17500.diff
Aug 6 2025, 11:52 PM
F18084769: D7736.id.diff
Aug 5 2025, 5:23 PM
F18081456: D7736.diff
Aug 5 2025, 12:20 AM
Unknown Object (File)
Jun 30 2025, 10:38 PM
Unknown Object (File)
Jun 29 2025, 10:56 PM
Unknown Object (File)
Jun 1 2025, 9:34 PM
Unknown Object (File)
May 30 2025, 9:54 PM
Unknown Object (File)
May 7 2025, 1:48 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4205: Implement Phragment
Commits
Restricted Diffusion Commit
rP67b37a5c1dc0: Fix deletion detection when updating based on ZIP
Summary

When the code to update based on ZIP went to look up the child fragments, it explicitly used the paths provided in the ZIP. This meant that we could never detect omissions because there'd never be a scenario where a child fragment would return but not exist in the ZIP. To fix this, the query should be using withLeadingPath instead of withPaths.

Test Plan

Uploaded a ZIP that omitted a file and saw the deleteFile get called (by placing debugging output in the code).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped