Paths

Table of Contentst

Diffusion Phabricator 4c124201623a

Replace "URI->setQueryParams()" after initialization with a constructor argument
4c124201623a
Actions

Description

Replace "URI->setQueryParams()" after initialization with a constructor argument

Summary: Ref T13250. See D20149. In a number of cases, we use setQueryParams() immediately after URI construction. To simplify this slightly, let the constructor take parameters, similar to HTTPSFuture.

Test Plan: See inlines.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13250

Differential Revision: https://secure.phabricator.com/D20151

Details

Provenance

epriestley	Authored on Feb 12 2019, 6:45 PM
epriestley	Pushed on Feb 14 2019, 7:46 PM

Reviewer

amckinley

Differential Revision

D20151: Replace "URI->setQueryParams()" after initialization with a constructor argument

Parents

rPeb73cb68ff5b: Raise a setup warning when locked configuration has a configuration value…

Branches

Unknown

Tags

Unknown

Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Build Status

Buildable 22003
Build 30056: Run Core Tests

Event Timeline

epriestley committed rP4c124201623a: Replace "URI->setQueryParams()" after initialization with a constructor argument (authored by epriestley).Feb 14 2019, 7:46 PM

epriestley added a task: T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules.

Harbormaster completed building B22003: rP4c124201623a: Replace "URI->setQueryParams()" after initialization with a constructor argument.Feb 14 2019, 7:48 PM

Changes (13)

Path

Size

src/

applications/

almanac/

controller/

AlmanacController.php

auth/

controller/

PhabricatorAuthOneTimeLoginController.php

future/

PhabricatorDuoFuture.php

diffusion/

view/

DiffusionView.php

diviner/

markup/

DivinerSymbolRemarkupRule.php

herald/

controller/

HeraldNewController.php

owners/

controller/

PhabricatorOwnersDetailController.php

phortune/

controller/

cart/

PhortuneCartCheckoutController.php

provider/

PhortunePayPalPaymentProvider.php

PhortunePaymentProvider.php

repository/

storage/

PhabricatorRepository.php

transactions/

editengine/

PhabricatorEditEngine.php

typeahead/

datasource/

PhabricatorTypeaheadDatasource.php

rP4c124201623a

View Options

src/applications/almanac/controller/AlmanacController.php

View Options

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

View Options

src/applications/auth/future/PhabricatorDuoFuture.php

View Options

src/applications/diffusion/view/DiffusionView.php

View Options

src/applications/diviner/markup/DivinerSymbolRemarkupRule.php

View Options

src/applications/herald/controller/HeraldNewController.php

View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

View Options

src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php

View Options

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

View Options

src/applications/phortune/provider/PhortunePaymentProvider.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Replace "URI->setQueryParams()" after initialization with a constructor argument4c124201623aActions

Description

Details

Event Timeline

Changes (13)

rP4c124201623a

src/applications/almanac/controller/AlmanacController.php

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

src/applications/auth/future/PhabricatorDuoFuture.php

src/applications/diffusion/view/DiffusionView.php

src/applications/diviner/markup/DivinerSymbolRemarkupRule.php

src/applications/herald/controller/HeraldNewController.php

src/applications/owners/controller/PhabricatorOwnersDetailController.php

src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

src/applications/phortune/provider/PhortunePaymentProvider.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Replace "URI->setQueryParams()" after initialization with a constructor argument
4c124201623a
Actions