Page MenuHomePhabricator

Replace "URI->setQueryParams()" after initialization with a constructor argument
ClosedPublic

Authored by epriestley on Feb 12 2019, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 7:37 AM
Unknown Object (File)
Feb 11 2024, 11:25 AM
Unknown Object (File)
Feb 7 2024, 7:21 AM
Unknown Object (File)
Jan 23 2024, 10:46 AM
Unknown Object (File)
Jan 19 2024, 4:43 PM
Unknown Object (File)
Jan 18 2024, 3:30 PM
Unknown Object (File)
Jan 15 2024, 4:39 PM
Unknown Object (File)
Jan 12 2024, 1:14 PM
Subscribers
None

Details

Summary

Ref T13250. See D20149. In a number of cases, we use setQueryParams() immediately after URI construction. To simplify this slightly, let the constructor take parameters, similar to HTTPSFuture.

Test Plan

See inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2019, 7:05 PM
Harbormaster failed remote builds in B21957: Diff 48114!
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2019, 7:11 PM
Harbormaster failed remote builds in B21961: Diff 48117!

Tests won't pass until D20149 lands.

src/applications/almanac/controller/AlmanacController.php
70–77

Edited and deleted an Almanac property.

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php
221–226

With password auth enabled, used a one-time login link to reset my password.

src/applications/auth/future/PhabricatorDuoFuture.php
106–120

Added a new Duo credential, survived the Duo MFA gate.

src/applications/diffusion/view/DiffusionView.php
84–90

Did not test, since it requires a repository with a submodule that points at another tracked repository and I don't have any of those on hand. Looked at it real carefully?

src/applications/diviner/markup/DivinerSymbolRemarkupRule.php
113–123

Typed @{class:quack} in remarkup and clicked it.

src/applications/herald/controller/HeraldNewController.php
135

Here and below, created a new Herald rule.

src/applications/owners/controller/PhabricatorOwnersDetailController.php
68–73

Clicked "View All" under "Recent Commits" on a package detail page.

src/applications/phortune/controller/cart/PhortuneCartCheckoutController.php
137–143

Used Fund to create a payment, clicked "Add new payment method".

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php
351–359

Did not test, Paypal "works" but is hard-coded to sandbox only and not in use in production today.

src/applications/phortune/provider/PhortunePaymentProvider.php
276

Edited, disabled, enabled payment providers in a Phortune merchant.

src/applications/repository/storage/PhabricatorRepository.php
831

Poked around Diffusion, pretty much everything uses this.

src/applications/transactions/editengine/PhabricatorEditEngine.php
1544

Browsed to a Calendar day view, created a new event, saw it select the correct day as a default.

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php
112–114

Typed ahead.

This revision is now accepted and ready to land.Feb 14 2019, 7:30 PM
This revision was automatically updated to reflect the committed changes.