HomePhabricator

(stable) Correct some straggling Ferret/Cursor interactions

Description

(stable) Correct some straggling Ferret/Cursor interactions

Summary:
See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan:
Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13266

Differential Revision: https://secure.phabricator.com/D20354

Details

Provenance
epriestleyAuthored on Mar 30 2019, 9:33 PM
epriestleyPushed on Apr 1 2019, 9:54 PM
Reviewer
amckinley
Differential Revision
D20354: Correct some straggling Ferret/Cursor interactions
Parents
rPbc1a8799532c: (stable) Promote 2019 Week 13
Branches
Unknown
Tags
Unknown
Tasks
T13266: Upgrading: Minor Changes to Query Paging / Cursors
Build Status
Buildable 22462
Build 30749: Run Core Tests