Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
F18821285: D20354.diff
Wed, Oct 22, 9:28 PM
F18818567: D20354.id.diff
Wed, Oct 22, 1:05 AM
F18795600: D20354.diff
Fri, Oct 17, 2:13 AM
F18759690: D20354.id48588.diff
Mon, Oct 6, 5:22 AM
F18531451: D20354.diff
Sep 7 2025, 4:07 AM
F18518600: D20354.diff
Sep 5 2025, 3:24 PM
F18494933: D20354.id.diff
Sep 4 2025, 3:26 PM
F17993521: D20354.diff
Aug 2 2025, 2:31 AM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable