Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 8:27 PM
Unknown Object (File)
Fri, May 30, 11:54 AM
Unknown Object (File)
Thu, May 29, 3:37 PM
Unknown Object (File)
Wed, May 28, 8:08 AM
Unknown Object (File)
Sat, May 17, 11:29 PM
Unknown Object (File)
May 7 2025, 10:23 PM
Unknown Object (File)
May 6 2025, 10:20 PM
Unknown Object (File)
May 6 2025, 10:20 PM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable