Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
F19026669: D20354.id.diff
Mon, Nov 24, 11:38 AM
F18999520: D20354.id48588.diff
Thu, Nov 20, 9:13 PM
F18999517: D20354.id48588.diff
Thu, Nov 20, 9:12 PM
F18943335: D20354.id48571.diff
Tue, Nov 11, 1:49 PM
F18936475: D20354.diff
Mon, Nov 10, 8:17 PM
F18928001: D20354.id48571.diff
Sun, Nov 9, 9:32 PM
F18843636: D20354.diff
Tue, Oct 28, 11:52 PM
F18821285: D20354.diff
Oct 22 2025, 9:28 PM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable