Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions

Authored by epriestley on Mar 30 2019, 9:38 PM.



See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 30 2019, 9:38 PM
epriestley requested review of this revision.Mar 30 2019, 9:39 PM
amckinley accepted this revision.Apr 1 2019, 7:27 PM
This revision is now accepted and ready to land.Apr 1 2019, 7:27 PM
This revision was automatically updated to reflect the committed changes.