Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
F14097223: D20354.id48588.diff
Tue, Nov 26, 6:31 AM
F14097220: D20354.id.diff
Tue, Nov 26, 6:31 AM
F14097218: D20354.diff
Tue, Nov 26, 6:30 AM
F14096765: D20354.id48588.diff
Tue, Nov 26, 5:05 AM
F14094282: D20354.diff
Mon, Nov 25, 3:05 PM
F14094125: D20354.diff
Mon, Nov 25, 2:27 PM
Unknown Object (File)
Oct 20 2024, 12:52 PM
Unknown Object (File)
Oct 17 2024, 11:00 AM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable