Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
F19939495: D20354.diff
Tue, Apr 14, 3:09 PM
F19933335: D20354.diff
Fri, Apr 10, 11:42 PM
F19919714: D20354.id48571.diff
Sun, Apr 5, 5:47 AM
F19834026: D20354.diff
Mar 11 2026, 2:35 AM
F19834024: D20354.diff
Mar 11 2026, 2:35 AM
F19804175: D20354.id48588.diff
Mar 2 2026, 5:46 AM
F19796405: D20354.id.diff
Feb 27 2026, 3:18 PM
F19779999: D20354.diff
Feb 23 2026, 6:27 PM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable