Page MenuHomePhabricator

Correct some straggling Ferret/Cursor interactions
ClosedPublic

Authored by epriestley on Mar 30 2019, 9:38 PM.
Tags
None
Referenced Files
F15514402: D20354.id48571.diff
Fri, Apr 18, 2:25 AM
F15451530: D20354.id48571.diff
Fri, Mar 28, 10:33 PM
F15449948: D20354.id48588.diff
Fri, Mar 28, 1:06 PM
F15446152: D20354.id.diff
Thu, Mar 27, 5:25 PM
F15439174: D20354.diff
Wed, Mar 26, 6:09 AM
F15413143: D20354.id.diff
Mar 19 2025, 5:11 PM
F15384203: D20354.id48571.diff
Mar 14 2025, 7:08 PM
F15374906: D20354.id48588.diff
Mar 12 2025, 8:33 PM
Subscribers
None

Details

Summary

See PHI1182. Ref T13266. The recent fixes didn't quite cover the case where you have a query, but order by something other than relevance, and page forward.

Refine the tests around building/selecting these columns and paging values a little bit to be more specific about what they care about.

Test Plan

Executed queries, then went to "Next Page", for:

  • query text, non-relevance order.
  • query text, relevance order.
  • no query text, non-relevance order.
  • no query text, relevance order.

Also, made an API call similar to the one in PHI1182.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable