HomePhabricator

(stable) Fix "Author's projects" Herald rules for revisions and diffs

Description

(stable) Fix "Author's projects" Herald rules for revisions and diffs

Summary:
See PHI71. These didn't get properly updated when we wrote Subprojects and Milestones, and should use materialized members, not raw members. Swap the query so projects you are an indirect member of (e.g., milestones you are a member of the parent for, and parent projects you are a member of a subproject of) are included in the result list.

Also fix a bad typeahead datasource.

Test Plan:

  • Ran a dry run with the test console, saw project PHIDs for milestones and parent projects in the raw field value.
  • Tried to set "Author's projects" to a user, no longer could.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18619

Details

Provenance
epriestleyAuthored on Sep 16 2017, 12:46 AM
epriestleyPushed on Sep 16 2017, 1:00 AM
Reviewer
amckinley
Differential Revision
D18619: Fix "Author's projects" Herald rules for revisions and diffs
Parents
rP76cdaa4f2d10: (stable) Swap "-R" and "serve" argument order for Mercurial
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18485
Build 24890: Run Core Tests