Page MenuHomePhabricator

Fix "Author's projects" Herald rules for revisions and diffs
ClosedPublic

Authored by epriestley on Sep 16 2017, 12:48 AM.
Tags
None
Referenced Files
F18339142: D18619.id.diff
Aug 25 2025, 9:11 PM
F18322135: D18619.diff
Aug 24 2025, 5:30 PM
F18034804: D18619.diff
Aug 3 2025, 1:18 AM
F17794786: D18619.id44708.diff
Jul 24 2025, 11:58 PM
F17766933: D18619.id.diff
Jul 23 2025, 5:06 AM
F17761423: D18619.id44708.diff
Jul 22 2025, 8:45 PM
F17759808: D18619.id44708.diff
Jul 22 2025, 6:51 PM
F17757881: D18619.id44706.diff
Jul 22 2025, 4:32 PM
Subscribers
None

Details

Summary

See PHI71. These didn't get properly updated when we wrote Subprojects and Milestones, and should use materialized members, not raw members. Swap the query so projects you are an indirect member of (e.g., milestones you are a member of the parent for, and parent projects you are a member of a subproject of) are included in the result list.

Also fix a bad typeahead datasource.

Test Plan
  • Ran a dry run with the test console, saw project PHIDs for milestones and parent projects in the raw field value.
  • Tried to set "Author's projects" to a user, no longer could.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable