Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 9:16 PM
Unknown Object (File)
Fri, Dec 6, 3:59 PM
Unknown Object (File)
Thu, Dec 5, 8:52 AM
Unknown Object (File)
Tue, Dec 3, 12:03 PM
Unknown Object (File)
Thu, Nov 28, 3:15 AM
Unknown Object (File)
Sun, Nov 24, 7:31 AM
Unknown Object (File)
Nov 14 2024, 6:50 PM
Unknown Object (File)
Nov 14 2024, 7:05 AM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable