Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
F18524511: D18938.diff
Sat, Sep 6, 12:58 PM
F18458967: D18938.id45411.diff
Mon, Sep 1, 3:52 PM
F18103765: D18938.id.diff
Aug 10 2025, 7:43 AM
F18103711: D18938.id45432.diff
Aug 10 2025, 7:24 AM
F18103300: D18938.id45432.diff
Aug 10 2025, 3:55 AM
F18099577: D18938.id45411.diff
Aug 9 2025, 6:31 AM
F18098855: D18938.diff
Aug 8 2025, 11:22 PM
F17973754: D18938.diff
Aug 1 2025, 4:29 PM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable