Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 4:05 AM
Unknown Object (File)
Sat, Jul 4, 4:05 AM
Unknown Object (File)
Mon, Jun 29, 10:56 PM
Unknown Object (File)
Sun, Jun 28, 2:54 PM
Unknown Object (File)
Thu, Jun 25, 1:12 PM
Unknown Object (File)
Thu, Jun 25, 1:12 PM
Unknown Object (File)
Thu, Jun 25, 3:57 AM
Unknown Object (File)
Thu, Jun 25, 3:52 AM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable