Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 2:37 PM
Unknown Object (File)
Sun, Mar 31, 12:09 AM
Unknown Object (File)
Mar 5 2024, 10:21 PM
Unknown Object (File)
Jan 11 2024, 5:10 PM
Unknown Object (File)
Dec 27 2023, 5:20 AM
Unknown Object (File)
Dec 18 2023, 4:02 PM
Unknown Object (File)
Nov 30 2023, 2:34 AM
Unknown Object (File)
Nov 16 2023, 4:07 AM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable