Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
F19811700: D18938.diff
Wed, Mar 4, 2:11 AM
F19517210: D18938.id.diff
Jan 15 2026, 8:43 AM
F19515789: D18938.diff
Jan 14 2026, 3:49 PM
F18839500: D18938.diff
Oct 27 2025, 5:01 PM
F18814692: D18938.diff
Oct 20 2025, 11:46 PM
F18798819: D18938.diff
Oct 17 2025, 8:59 AM
F18763797: D18938.id45411.diff
Oct 7 2025, 2:17 AM
F18760200: D18938.id.diff
Oct 6 2025, 8:29 AM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable