Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
F18839500: D18938.diff
Oct 27 2025, 5:01 PM
F18814692: D18938.diff
Oct 20 2025, 11:46 PM
F18798819: D18938.diff
Oct 17 2025, 8:59 AM
F18763797: D18938.id45411.diff
Oct 7 2025, 2:17 AM
F18760200: D18938.id.diff
Oct 6 2025, 8:29 AM
F18757174: D18938.diff
Oct 5 2025, 3:54 PM
F18702483: D18938.id45432.diff
Sep 28 2025, 12:18 AM
F18524511: D18938.diff
Sep 6 2025, 12:58 PM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable