Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 9:30 AM
Unknown Object (File)
Thu, Jan 30, 2:50 PM
Unknown Object (File)
Fri, Jan 24, 11:19 PM
Unknown Object (File)
Fri, Jan 24, 11:19 PM
Unknown Object (File)
Fri, Jan 24, 11:18 PM
Unknown Object (File)
Fri, Jan 24, 11:18 PM
Unknown Object (File)
Fri, Jan 24, 3:59 PM
Unknown Object (File)
Sat, Jan 18, 5:56 AM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable