Set time and date on Calendar Date Control form
2bdf8ae5a234
Actions

Description

Set time and date on Calendar Date Control form

Summary: Recurring events will fatal a Calendar with this not set. newDateTime requires a date and time to be called property. I think this is correct fix? Fixes T10766

Test Plan: Build a recurring event, pull up /calendar/, see recurring events as expected. Previously, fatal.

Reviewers: lpriestley, epriestley

Reviewed By: epriestley

Subscribers: CodeMouse92, Korvin

Maniphest Tasks: T10766

Differential Revision: https://secure.phabricator.com/D15666

Details

Provenance

chad	Authored on Apr 9 2016, 6:50 PM
chad	Pushed on Apr 9 2016, 7:01 PM

Reviewer

epriestley

Differential Revision

D15666: Set time and date on Calendar Date Control form

Parents

rP997460f12fba: When proxying cluster HTTP requests, forward only selected headers

Branches

Unknown

Tags

Unknown

Tasks

T10766: Calendar - Unhandled Exception

Build Status

Buildable 11622
Build 14535: Run Core Tests

Event Timeline

chad committed rP2bdf8ae5a234: Set time and date on Calendar Date Control form (authored by chad).Apr 9 2016, 7:01 PM

chad added a task: T10766: Calendar - Unhandled Exception.

Harbormaster completed building B11622: rP2bdf8ae5a234: Set time and date on Calendar Date Control form.Apr 9 2016, 7:01 PM

I'm on stable, so this hasn't hit mine yet. Is there a particular way to patch this in without switching branches, or can it be promoted to stable (thereby stabilizing stable?) Sorry to be a hassle. It's one of those days. >.>

Changes (1)

Path

Size

src/

view/

form/

control/

AphrontFormDateControlValue.php

rP2bdf8ae5a234

View Options

src/view/form/control/AphrontFormDateControlValue.php