Set time and date on Calendar Date Control form
ClosedPublic
Actions

Authored by chad on Apr 9 2016, 6:52 PM.

Details

Reviewers

epriestley
lpriestley

Maniphest Tasks

T10766: Calendar - Unhandled Exception

Commits

rP5ddaf5289862: (stable) Set time and date on Calendar Date Control form
rP2bdf8ae5a234: Set time and date on Calendar Date Control form

Summary

Recurring events will fatal a Calendar with this not set. newDateTime requires a date and time to be called property. I think this is correct fix? Fixes T10766

Test Plan

Build a recurring event, pull up /calendar/, see recurring events as expected. Previously, fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37752.Apr 9 2016, 6:52 PM

chad retitled this revision from to Set time and date on Calendar Date Control form.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, lpriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptApr 9 2016, 6:52 PM

chad updated this object.Apr 9 2016, 6:53 PM

chad added a task: T10766: Calendar - Unhandled Exception.

CodeMouse92 awarded a token.Apr 9 2016, 6:54 PM

CodeMouse92 added a subscriber: CodeMouse92.

Thanks!

This revision is now accepted and ready to land.Apr 9 2016, 6:56 PM

Closed by commit rP2bdf8ae5a234: Set time and date on Calendar Date Control form (authored by chad, committed by chad). · Explain WhyApr 9 2016, 7:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

control/

AphrontFormDateControlValue.php

2 lines

Diff 37754

View Options

src/view/form/control/AphrontFormDateControlValue.php

Set time and date on Calendar Date Control formClosedPublicActions