Page MenuHomePhabricator

Remove indirect loads of Differential revisions from Releeph requests
ClosedPublic

Authored by epriestley on Apr 20 2014, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 1:35 AM
Unknown Object (File)
Tue, Apr 2, 6:20 AM
Unknown Object (File)
Mar 15 2024, 11:38 AM
Unknown Object (File)
Feb 15 2024, 11:04 PM
Unknown Object (File)
Feb 1 2024, 7:11 PM
Unknown Object (File)
Dec 30 2023, 6:03 PM
Unknown Object (File)
Dec 26 2023, 7:52 PM
Unknown Object (File)
Dec 23 2023, 1:30 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP28696d08ac42: Remove indirect loads of Differential revisions from Releeph requests
Summary

Ref T3551. Currently, there are many layers of indirection between pull requests and revisions. After D8822, revisions and other types of requested objects are recorded directly on the request. This allows us to simplify data access and querying.

A lot of stuff here is doing instanceof checks to keep APIs stable, but most of those can go away in the long run.

Test Plan
  • Browsed requests.
  • Verified revision-dependent fields (like "Revision", "Size", "Churn") still render correctly.
  • Called releeph.queryrequests.
  • Called releephwork.nextrequest.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove indirect loads of Differential revisions from Releeph requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2014, 5:03 PM
epriestley updated this revision to Diff 20942.

Closed by commit rP28696d08ac42 (authored by @epriestley).