Diffusion Phabricator 26d6096e0a5b

When reviewing, always show "Accept" checkboxes for packages/projects, even if…
26d6096e0a5b
Actions

Description

When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox

Summary: Fixes T12533.

Test Plan:

Screen Shot 2017-04-10 at 5.09.11 PM.png (328×774 px, 34 KB)

Reviewers: chad, lvital

Reviewed By: lvital

Maniphest Tasks: T12533

Differential Revision: https://secure.phabricator.com/D17652

Details

Provenance

epriestley	Authored on Apr 11 2017, 12:09 AM
epriestley	Pushed on Apr 11 2017, 12:28 AM

Reviewer

lvital

Differential Revision

D17652: When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox

Parents

rP5cf53f7b3b42: Fix some minor curtain overflow/wrap issues

Branches

Unknown

Tags

Unknown

Tasks

T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not

Build Status

Buildable 16385
Build 21794: Run Core Tests

Event Timeline

epriestley committed rP26d6096e0a5b: When reviewing, always show "Accept" checkboxes for packages/projects, even if… (authored by epriestley).Apr 11 2017, 12:28 AM

epriestley added a task: T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not.

Harbormaster completed building B16385: rP26d6096e0a5b: When reviewing, always show "Accept" checkboxes for packages/projects, even if….Apr 11 2017, 12:29 AM

Changes (1)

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionActionTransaction.php

rP26d6096e0a5b

View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php