When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox
ClosedPublic
Actions

Authored by epriestley on Apr 11 2017, 12:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 11, 6:08 AM

	Unknown Object (File)
	Wed, Oct 30, 8:42 AM

	Unknown Object (File)
	Mon, Oct 28, 5:23 AM

	Unknown Object (File)
	Sun, Oct 27, 7:07 AM

	Unknown Object (File)
	Oct 11 2024, 5:56 PM

	Unknown Object (File)
	Oct 6 2024, 11:01 PM

	Unknown Object (File)
	Oct 1 2024, 3:17 PM

	Unknown Object (File)
	Sep 25 2024, 2:10 PM

View All Files

Subscribers

None

Details

Reviewers

chad
lvital

Maniphest Tasks

T12533: Reducing "Accept" action to not render a checkbox when only one package or project would be accepted is perhaps more confusing than not

Commits

rP26d6096e0a5b: When reviewing, always show "Accept" checkboxes for packages/projects, even if…

Summary

Fixes T12533.

Test Plan

Screen Shot 2017-04-10 at 5.09.11 PM.png (328×774 px, 34 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 11 2017, 12:10 AM

Harbormaster completed remote builds in B16384: Diff 42454.Apr 11 2017, 12:11 AM

lvital accepted this revision.Apr 11 2017, 12:22 AM

This revision is now accepted and ready to land.Apr 11 2017, 12:22 AM

Closed by commit rP26d6096e0a5b: When reviewing, always show "Accept" checkboxes for packages/projects, even if… (authored by epriestley, committed by epriestley). · Explain WhyApr 11 2017, 12:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionActionTransaction.php

8 lines

Diff 42455

View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkboxClosedPublicActions