Page MenuHomePhabricator

Fix file attach bug in Macro
ClosedPublic

Authored by chad on May 6 2017, 2:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 14 2026, 10:57 AM
Unknown Object (File)
Mar 2 2026, 3:22 AM
Unknown Object (File)
Feb 28 2026, 2:15 PM
Unknown Object (File)
Nov 23 2025, 7:46 AM
Unknown Object (File)
Nov 22 2025, 2:08 PM
Unknown Object (File)
Oct 19 2025, 8:07 AM
Unknown Object (File)
Oct 15 2025, 10:33 PM
Unknown Object (File)
Oct 10 2025, 9:02 PM
Subscribers

Details

Summary

This was mis-tested by only using one account, which could always see the image. External transaction moved file attachment to the modular transaction for file and audio instead.

Test Plan

Test adding audio and a macro on a pleb account, visit with normal account and see macro fine.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 6 2017, 2:46 AM

(I'll cherry-pick this before deploying tomorrow.)

This revision was automatically updated to reflect the committed changes.

ive learned so much about transactions this week