Page MenuHomePhabricator

Fix file attach bug in Macro
ClosedPublic

Authored by chad on May 6 2017, 2:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 18, 2:08 PM
Unknown Object (File)
May 20 2025, 1:13 PM
Unknown Object (File)
May 8 2025, 6:22 AM
Unknown Object (File)
Apr 27 2025, 5:23 PM
Unknown Object (File)
Apr 18 2025, 3:16 AM
Unknown Object (File)
Apr 17 2025, 8:15 PM
Unknown Object (File)
Apr 15 2025, 4:17 AM
Unknown Object (File)
Apr 10 2025, 9:55 AM
Subscribers

Details

Summary

This was mis-tested by only using one account, which could always see the image. External transaction moved file attachment to the modular transaction for file and audio instead.

Test Plan

Test adding audio and a macro on a pleb account, visit with normal account and see macro fine.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 6 2017, 2:46 AM

(I'll cherry-pick this before deploying tomorrow.)

This revision was automatically updated to reflect the committed changes.

ive learned so much about transactions this week