HomePhabricator

Allow null for token expiration date

Description

Allow null for token expiration date

Summary: At least under GitHub, the token value is stored as "null", and not missing. And null > anything is false, so Phabricator thinks the token is expired or not there.

Test Plan: http://ph.vm/settings/panel/external/ before shows "No OAuth Access Token," and after it says "Active OAuth Token".

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7466

Details

Provenance
aviveyAuthored on Oct 31 2013, 12:19 AM
epriestleyCommitted on Oct 31 2013, 12:19 AM
Reviewer
epriestley
Differential Revision
D7466: Allow null for token expiration date
Parents
rP3a39b01233db: Add "RepositoryStatusMessage" and detailed information about initilization
Branches
Unknown
Tags
Unknown

Event Timeline