Page MenuHomePhabricator

Allow null for token expiration date
ClosedPublic

Authored by avivey on Oct 31 2013, 12:18 AM.
Tags
None
Referenced Files
F18408875: D7466.id.diff
Sat, Aug 30, 3:13 AM
F18394120: D7466.diff
Fri, Aug 29, 9:42 AM
F17925029: D7466.id16824.diff
Jul 30 2025, 10:51 AM
F17792437: D7466.id16823.diff
Jul 24 2025, 10:49 PM
F17768497: D7466.id16824.diff
Jul 23 2025, 6:48 AM
F17752568: D7466.id16823.diff
Jul 22 2025, 7:20 AM
Unknown Object (File)
May 11 2025, 9:52 AM
Unknown Object (File)
Apr 29 2025, 11:22 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2250ee6aa6b8: Allow null for token expiration date
Summary

At least under GitHub, the token value is stored as "null", and not missing. And null > anything is false, so Phabricator thinks the token is expired or not there.

Test Plan

http://ph.vm/settings/panel/external/ before shows "No OAuth Access Token," and after it says "Active OAuth Token".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley closed this revision.

Closed by commit rP2250ee6aa6b8 (authored by Aviv Eyal <aeyal@groupon.com>, committed by @epriestley).