Page MenuHomePhabricator

Allow null for token expiration date
ClosedPublic

Authored by avivey on Oct 31 2013, 12:18 AM.
Tags
None
Referenced Files
F18765226: D7466.diff
Tue, Oct 7, 10:18 AM
F18755053: D7466.id.diff
Sun, Oct 5, 3:24 AM
F18751089: D7466.diff
Oct 4 2025, 9:43 AM
F18671687: D7466.id16823.diff
Sep 25 2025, 4:50 AM
F18651860: D7466.diff
Sep 21 2025, 5:46 AM
F18593587: D7466.id16823.diff
Sep 12 2025, 3:19 PM
F18592880: D7466.id16823.diff
Sep 12 2025, 1:21 PM
F18592669: D7466.diff
Sep 12 2025, 12:54 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2250ee6aa6b8: Allow null for token expiration date
Summary

At least under GitHub, the token value is stored as "null", and not missing. And null > anything is false, so Phabricator thinks the token is expired or not there.

Test Plan

http://ph.vm/settings/panel/external/ before shows "No OAuth Access Token," and after it says "Active OAuth Token".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley closed this revision.

Closed by commit rP2250ee6aa6b8 (authored by Aviv Eyal <aeyal@groupon.com>, committed by @epriestley).