HomePhabricator

Add a specialized cache for storing "has setup ever worked?"

Description

Add a specialized cache for storing "has setup ever worked?"

Summary:
Ref T11613. In D16503/T11598 I refined the setup flow to improve messaging for early-stage setup issues, but failed to fully untangle things.

We sometimes still try to access a cache which uses configuration before we build configuration, which causes an error.

Instead, store "are we in flight / has setup ever worked?" in a separate cache which doesn't use the cache namespace. This stops us from trying to read config before building config.

Test Plan:
Hit bad extension error with a fake extension, got a proper setup help page:

Screen Shot 2016-09-12 at 7.30.45 AM.png (1×1 px, 137 KB)

Solved the error, reloaded, broke things again, got a "friendly" page:

Screen Shot 2016-09-12 at 7.31.19 AM.png (1×1 px, 66 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11613

Differential Revision: https://secure.phabricator.com/D16542

Details

Provenance
epriestleyAuthored on Sep 12 2016, 2:31 PM
epriestleyPushed on Sep 12 2016, 3:04 PM
Reviewer
chad
Differential Revision
D16542: Add a specialized cache for storing "has setup ever worked?"
Parents
rPb822ceb6d563: Rework new favicon
Branches
Unknown
Tags
Unknown
Tasks
T11613: New install exception is wrong if preflight setup checks fail
Build Status
Buildable 13687
Build 17654: Run Core Tests