Page MenuHomePhabricator

Add a specialized cache for storing "has setup ever worked?"
ClosedPublic

Authored by epriestley on Sep 12 2016, 2:36 PM.
Tags
None
Referenced Files
F15486777: D16542.id39806.diff
Thu, Apr 10, 9:36 AM
F15485816: D16542.diff
Thu, Apr 10, 2:45 AM
F15470967: D16542.id39807.diff
Sat, Apr 5, 2:20 AM
F15463680: D16542.diff
Wed, Apr 2, 2:09 AM
F15427623: D16542.id39807.diff
Sun, Mar 23, 3:12 PM
F15425828: D16542.id39807.diff
Sun, Mar 23, 6:20 AM
F15403130: D16542.id39807.diff
Tue, Mar 18, 1:58 AM
F15400529: D16542.id39807.diff
Mon, Mar 17, 12:20 PM
Subscribers
None

Details

Summary

Ref T11613. In D16503/T11598 I refined the setup flow to improve messaging for early-stage setup issues, but failed to fully untangle things.

We sometimes still try to access a cache which uses configuration before we build configuration, which causes an error.

Instead, store "are we in flight / has setup ever worked?" in a separate cache which doesn't use the cache namespace. This stops us from trying to read config before building config.

Test Plan

Hit bad extension error with a fake extension, got a proper setup help page:

Screen Shot 2016-09-12 at 7.30.45 AM.png (1×1 px, 137 KB)

Solved the error, reloaded, broke things again, got a "friendly" page:

Screen Shot 2016-09-12 at 7.31.19 AM.png (1×1 px, 66 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add a specialized cache for storing "has setup ever worked?".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 12 2016, 3:03 PM
src/infrastructure/env/PhabricatorEnv.php
326–332

(I moved these down to avoid an error on the call to array_key_exists() where $cache might not exist yet.)

This revision was automatically updated to reflect the committed changes.