HomePhabricator

Search symbols by ctrl/cmd-click

Description

Search symbols by ctrl/cmd-click

Summary:
Refs T8302.
V1 of the implementation. This replaces the previous mode, but I guess there's no real reason we can't have
some symbols always clickable and the rest require modifier.

I'm also a little concerned about discoverability; Holding down ctrl/cmd will make the cursor change, so there's
some hint that something might be up, but that's probably not obvious enough.

Test Plan:
Tested in diffusion and differential and differential comments on:

  • Windows/Chrome,
  • Windows/IE 11
  • LInux/Firefox 38
  • Mac/Chrome
  • Mac/Safari

Reviewers: chad, epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley, joshuaspence

Maniphest Tasks: T8302

Differential Revision: https://secure.phabricator.com/D13034

Details

Provenance
aviveyAuthored on
epriestleyCommitted on May 28 2015, 10:33 PM
epriestleyPushed on May 28 2015, 10:33 PM
Reviewer
Blessed Reviewers
Differential Revision
D13034: Search symbols by ctrl/cmd-click
Parents
rPc7de17663a9d: Conpherence - massage email notification to have proper link to how to update…
Branches
Unknown
Tags
Unknown
Tasks
T8302: Maybe allow ctrl-click to search for any symbol?