Search symbols by ctrl/cmd-click
ClosedPublic
Actions

Authored by avivey on May 27 2015, 4:07 AM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8302: Maybe allow ctrl-click to search for any symbol?

Commits

Restricted Diffusion Commit
rP1aa8bc319b52: Search symbols by ctrl/cmd-click

Summary

Refs T8302.
V1 of the implementation. This replaces the previous mode, but I guess there's no real reason we can't have
some symbols always clickable and the rest require modifier.

I'm also a little concerned about discoverability; Holding down ctrl/cmd will make the cursor change, so there's
some hint that something might be up, but that's probably not obvious enough.

Test Plan

Tested in diffusion and differential and differential comments on:

Windows/Chrome,
Windows/IE 11
LInux/Firefox 38
Mac/Chrome
Mac/Safari

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 31426.May 27 2015, 4:07 AM

avivey retitled this revision from to Search symbols by ctrl/cmd-click.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

avivey updated this object.

avivey added a task: T8302: Maybe allow ctrl-click to search for any symbol?.

avivey added a subscriber: joshuaspence.

Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 27 2015, 4:07 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

avivey planned changes to this revision.May 27 2015, 4:07 AM

avivey added inline comments.May 27 2015, 4:12 AM

webroot/rsrc/externals/javelin/lib/DOM.js
719	This would leave an extra space at the end of the class attribute, so the map later would fail to identify it. OTOH, using the css class gave me some more grief, which I guess is similar to why sigils were introduced.

celery

avivey planned changes to this revision.May 27 2015, 5:23 AM

Properly tested now...

avivey mentioned this in T8090: Allow Harbormaster to perform change handoff in a defensible way.May 28 2015, 12:10 AM

One inline -- is double-click-to-select still working? Can we plausibly make it work?

webroot/rsrc/js/application/repository/repository-crossreference.js
48	The reason for this logic was to let you double-click something to select it and copy/paste it instead of following the symbol lookup. That probably doesn't work anymore?

ctrl/cmd-double-click doesn't select, but [no-ctrl/cmd]-double click does. We can return the timeout to allow ctrl-double-click to select, but I think that may be a bit much.

epriestley accepted this revision.May 28 2015, 10:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 28 2015, 10:32 PM

Closed by commit rP1aa8bc319b52: Search symbols by ctrl/cmd-click (authored by avivey, committed by epriestley). · Explain WhyMay 28 2015, 10:33 PM

This revision was automatically updated to reflect the committed changes.

chad mentioned this in T8501: Cursor stuck in 'help' mode after Ctrl+F.Jun 10 2015, 7:57 PM