(stable) Remove 'isPartial' parameter with no effect
167e58479cd5
Actions

Description

(stable) Remove 'isPartial' parameter with no effect

Summary: Fixes T12536. Nothing reads this parameter; PhabricatorFile::newChunkedFile sets the isPartial flag automatically.

Test Plan: Grepped for isPartial.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12536

Differential Revision: https://secure.phabricator.com/D17654

Details

Provenance

epriestley	Authored on Apr 11 2017, 5:54 PM
epriestley	Pushed on Apr 11 2017, 6:42 PM

Reviewer

chad

Differential Revision

D17654: Remove 'isPartial' parameter with no effect

Parents

rPf624c8238123: (stable) Fix an issue where rejecting reviewers weren't powerful enough

Branches

Unknown

Tags

Unknown

Tasks

T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`

Build Status

Buildable 16394
Build 21807: Run Core Tests

Event Timeline

epriestley committed rP167e58479cd5: (stable) Remove 'isPartial' parameter with no effect (authored by epriestley).Apr 11 2017, 6:42 PM

epriestley added a task: T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`.

Harbormaster completed building B16394: rP167e58479cd5: (stable) Remove 'isPartial' parameter with no effect.Apr 11 2017, 6:43 PM

epriestley mentioned this in T12537: Ambiguous display of commits in maniphest.Apr 12 2017, 3:25 PM

Changes (1)

Path

Size

src/

applications/

files/

uploadsource/

PhabricatorFileUploadSource.php

rP167e58479cd5

View Options

src/applications/files/uploadsource/PhabricatorFileUploadSource.php