Paths

Table of Contentst

Differential D17654

Remove 'isPartial' parameter with no effect
ClosedPublic
Actions

Authored by epriestley on Apr 11 2017, 5:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 7:41 PM

	Unknown Object (File)
	Sat, Nov 16, 8:36 AM

	Unknown Object (File)
	Tue, Nov 12, 2:37 PM

	Unknown Object (File)
	Fri, Nov 8, 3:19 PM

	Unknown Object (File)
	Thu, Oct 24, 10:24 PM

	Unknown Object (File)
	Oct 12 2024, 8:41 PM

	Unknown Object (File)
	Oct 12 2024, 2:28 AM

	Unknown Object (File)
	Oct 2 2024, 5:34 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`

Commits

rP167e58479cd5: (stable) Remove 'isPartial' parameter with no effect
rP21709a2bbc1a: Remove 'isPartial' parameter with no effect

Summary

Fixes T12536. Nothing reads this parameter; PhabricatorFile::newChunkedFile sets the isPartial flag automatically.

Test Plan

Grepped for isPartial.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 11 2017, 5:56 PM

Harbormaster completed remote builds in B16391: Diff 42460.Apr 11 2017, 5:57 PM

chad accepted this revision.Apr 11 2017, 6:04 PM

This revision is now accepted and ready to land.Apr 11 2017, 6:04 PM

Closed by commit rP21709a2bbc1a: Remove 'isPartial' parameter with no effect (authored by epriestley, committed by epriestley). · Explain WhyApr 11 2017, 6:29 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`.Apr 11 2017, 6:42 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

uploadsource/

PhabricatorFileUploadSource.php

4 lines

Diff 42462

src/applications/files/uploadsource/PhabricatorFileUploadSource.php

Loading...