Page MenuHomePhabricator
Differential D17654

Remove 'isPartial' parameter with no effect
ClosedPublic
Actions

Authored by epriestley on Apr 11 2017, 5:56 PM.
Tags
None
Referenced Files
F15494471: D17654.diff
Sun, Apr 13, 12:02 AM
F15493037: D17654.id42460.diff
Sat, Apr 12, 8:57 PM
F15490874: D17654.id42462.diff
Fri, Apr 11, 9:16 PM
F15486079: D17654.id.diff
Thu, Apr 10, 4:49 AM
F15485404: D17654.diff
Wed, Apr 9, 11:30 PM
F15484727: D17654.diff
Wed, Apr 9, 7:46 PM
F15472267: D17654.id42462.diff
Sat, Apr 5, 12:17 PM
F15469207: D17654.id42462.diff
Fri, Apr 4, 10:36 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12536: `PhabricatorRepositoryGitCommitMessageParserWorker` fails with `Got unexpected parameters: isPartial`
Commits
rP167e58479cd5: (stable) Remove 'isPartial' parameter with no effect
rP21709a2bbc1a: Remove 'isPartial' parameter with no effect
Summary

Fixes T12536. Nothing reads this parameter; PhabricatorFile::newChunkedFile sets the isPartial flag automatically.

Test Plan

Grepped for isPartial.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
files/
uploadsource/
4 lines

Diff 42462

View Options

src/applications/files/uploadsource/PhabricatorFileUploadSource.php

Loading...
Phabricator · Built by Phacility