HomePhabricator

(stable) Fix an issue where rejecting reviewers weren't powerful enough

Description

(stable) Fix an issue where rejecting reviewers weren't powerful enough

Summary:
Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan:

  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17653

Details

Provenance
epriestleyAuthored on Apr 11 2017, 4:51 PM
epriestleyPushed on Apr 11 2017, 4:54 PM
Reviewer
chad
Differential Revision
D17653: Fix an issue where rejecting reviewers weren't powerful enough
Parents
rP944f7da48670: (stable) Correct two parameter strictness issues with file uploads
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16390
Build 21801: Run Core Tests