HomePhabricator

Refine bucketing and display rules for voided "Accepts" in Differential

Description

Refine bucketing and display rules for voided "Accepts" in Differential

Summary:
See PHI190. This clarifies the ruleset a bit:

  • If you accepted, then the author used "Request Review" explicitly, we now show "Accepted Earlier" instead of "Accepted" in the "Reviewers" list on the main revision page. This makes it sligthly more clear why the revision is back in your review queue without picking through the transaction log.
  • Instead of moving all non-current accepts into "Ready to Review", move only voided accepts into "Ready to Review". This stops us from pulling older accepts which haven't been voided (which could have been incorrectly pulled) and correctly pulls older, voided accepts from before an update (for example: accept, then request review, then update) and generally aligns better with intent/expectation.

Test Plan:

  • Accepted, requested review.
  • Saw reviewer as "Accepted Earlier".
  • Saw review in "Ready to Review" bucket.
  • Accepted, updated (with sticky accept).
  • Saw reviewer as "Accepted Prior Diff".
  • Saw review as "Waiting on Authors".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18764

Details

Provenance
epriestleyAuthored on Nov 6 2017, 7:51 PM
epriestleyPushed on Nov 7 2017, 11:35 PM
Reviewer
amckinley
Differential Revision
D18764: Refine bucketing and display rules for voided "Accepts" in Differential
Parents
rP587faa6f677c: Remove some defunct old-style transaction policy checks
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18813
Build 25359: Run Core Tests