Page MenuHomePhabricator

Refine bucketing and display rules for voided "Accepts" in Differential
ClosedPublic

Authored by epriestley on Nov 6 2017, 8:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:58 PM
Unknown Object (File)
Thu, Apr 18, 10:15 AM
Unknown Object (File)
Sat, Apr 13, 9:49 AM
Unknown Object (File)
Apr 10 2024, 12:30 AM
Unknown Object (File)
Apr 9 2024, 4:52 PM
Unknown Object (File)
Apr 1 2024, 6:12 PM
Unknown Object (File)
Mar 31 2024, 6:16 PM
Unknown Object (File)
Feb 11 2024, 5:23 AM
Subscribers
None

Details

Summary

See PHI190. This clarifies the ruleset a bit:

  • If you accepted, then the author used "Request Review" explicitly, we now show "Accepted Earlier" instead of "Accepted" in the "Reviewers" list on the main revision page. This makes it sligthly more clear why the revision is back in your review queue without picking through the transaction log.
  • Instead of moving all non-current accepts into "Ready to Review", move only voided accepts into "Ready to Review". This stops us from pulling older accepts which haven't been voided (which could have been incorrectly pulled) and correctly pulls older, voided accepts from before an update (for example: accept, then request review, then update) and generally aligns better with intent/expectation.
Test Plan
  • Accepted, requested review.
  • Saw reviewer as "Accepted Earlier".
  • Saw review in "Ready to Review" bucket.
  • Accepted, updated (with sticky accept).
  • Saw reviewer as "Accepted Prior Diff".
  • Saw review as "Waiting on Authors".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable