Diffusion Phabricator 10b3ddf42657

Possibly fix memes in email
10b3ddf42657
Actions

Description

Possibly fix memes in email

Summary:
Depends on D19201. Ref T13101. This likely produces relatively stable-ish image references for email.

They currently TTL after 30 days but this makes the jokes more exclusive and special so it's a feature, not a bug.

Test Plan: I'm just going to test this in production because I'm a ninja superstar developer.

Maniphest Tasks: T13101

Differential Revision: https://secure.phabricator.com/D19203

Details

Provenance

epriestley	Authored on Mar 8 2018, 7:02 PM
epriestley	Pushed on Mar 8 2018, 7:09 PM

Differential Revision

D19203: Possibly fix memes in email

Parents

rPa3d282d33efe: Somewhat improve meme transform code so it is merely very bad

Branches

Unknown

Tags

Unknown

Tasks

T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy

Build Status

Buildable 19805
Build 26832: Run Core Tests

Event Timeline

epriestley committed rP10b3ddf42657: Possibly fix memes in email (authored by epriestley).Mar 8 2018, 7:09 PM

epriestley added a task: T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

Harbormaster completed building B19805: rP10b3ddf42657: Possibly fix memes in email.Mar 8 2018, 7:10 PM

Changes (2)

Path

Size

src/

applications/

macro/

engine/

PhabricatorMemeEngine.php

markup/

PhabricatorMemeRemarkupRule.php

rP10b3ddf42657

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php