Somewhat improve meme transform code so it is merely very bad
a3d282d33efe
Actions

Description

Somewhat improve meme transform code so it is merely very bad

Summary: Depends on D19200. Fixes T5258. Ref T13101. Attempt to simplify and modernize this code and improve error handling.

Test Plan: did real hard dank memes

Maniphest Tasks: T13101, T5258

Differential Revision: https://secure.phabricator.com/D19201

Details

Provenance

epriestley	Authored on Mar 8 2018, 6:27 PM
epriestley	Pushed on Mar 8 2018, 7:08 PM

Differential Revision

D19201: Somewhat improve meme transform code so it is merely very bad

Parents

rPc7408f27977d: PhabricatorMemeEngine HA HA HA HA

Branches

Unknown

Tags

Unknown

Tasks

T5258: Memes use older image transform code without modern error handling
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy

Build Status

Buildable 19804
Build 26831: Run Core Tests

Event Timeline

epriestley committed rPa3d282d33efe: Somewhat improve meme transform code so it is merely very bad (authored by epriestley).Mar 8 2018, 7:08 PM

epriestley added a task: T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

epriestley added a task: T5258: Memes use older image transform code without modern error handling.

Harbormaster completed building B19804: rPa3d282d33efe: Somewhat improve meme transform code so it is merely very bad.Mar 8 2018, 7:10 PM

Changes (2)

Path

Size

src/

applications/

files/

PhabricatorImageTransformer.php

macro/

engine/

PhabricatorMemeEngine.php

rPa3d282d33efe

View Options

src/applications/files/PhabricatorImageTransformer.php