HomePhabricator

Add hard stops on empty batch edit sets

Description

Add hard stops on empty batch edit sets

Summary:
Ref T8637. If a user tries to batch edit a list of tasks which can't be edited, we fall through to withIDs(array()), which can affect everything.

Explicitly stop batch editing if we don't have valid IDs or valid tasks.

The UI sort-of warns you that something is wrong, but this is ultimately a pretty severe UX issue. I'll fix the underlying Query in the next diff.

Test Plan: Tried to batch edit a list of tasks I didn't have permission to edit.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: lloyd.oliver, epriestley

Maniphest Tasks: T8637

Differential Revision: https://secure.phabricator.com/D13388

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jun 22 2015, 6:48 PM
Reviewer
btrahan
Differential Revision
D13388: Add hard stops on empty batch edit sets
Parents
rPd1983560a6bc: Show when objects have a non-default policy
Branches
Unknown
Tags
Unknown
Tasks
T8637: Maniphest batch editor can affect far too many tasks