Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 1:59 AM
Unknown Object (File)
Wed, Jan 22, 10:59 AM
Unknown Object (File)
Wed, Jan 22, 10:59 AM
Unknown Object (File)
Wed, Jan 22, 10:59 AM
Unknown Object (File)
Tue, Jan 21, 10:28 AM
Unknown Object (File)
Tue, Jan 21, 5:45 AM
Unknown Object (File)
Sun, Jan 5, 7:39 PM
Unknown Object (File)
Dec 28 2024, 2:22 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable