Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F19911808: D17369.diff
Thu, Apr 2, 3:07 PM
F19911776: D17369.diff
Thu, Apr 2, 2:54 PM
F19906522: D17369.id41766.diff
Wed, Apr 1, 1:02 AM
F19813471: D17369.diff
Mar 4 2026, 9:33 AM
F19685435: D17369.id41766.diff
Feb 9 2026, 8:44 AM
F19671567: D17369.id41767.diff
Feb 8 2026, 1:18 AM
F19617414: D17369.diff
Feb 4 2026, 6:15 AM
F19569415: D17369.id41766.diff
Jan 31 2026, 11:32 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable