Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F19468464: D17369.diff
Sun, Jan 4, 4:38 AM
F18889885: D17369.id41767.diff
Nov 7 2025, 9:05 AM
F18850218: D17369.id41766.diff
Oct 30 2025, 3:07 PM
F18843863: D17369.id.diff
Oct 29 2025, 1:28 AM
F18842998: D17369.id41766.diff
Oct 28 2025, 8:21 PM
F18832068: D17369.id.diff
Oct 25 2025, 7:09 PM
F18826617: D17369.diff
Oct 24 2025, 4:54 AM
F18759971: D17369.diff
Oct 6 2025, 7:07 AM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable