Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F15547405: D17369.id.diff
Sat, Apr 26, 7:01 PM
F15540085: D17369.diff
Fri, Apr 25, 6:31 AM
F15481667: D17369.id41767.diff
Tue, Apr 8, 10:22 PM
F15455915: D17369.diff
Mar 30 2025, 5:41 AM
F15442690: D17369.diff
Mar 27 2025, 12:00 AM
F15390874: D17369.id41766.diff
Mar 15 2025, 7:09 AM
F15390150: D17369.id41766.diff
Mar 15 2025, 5:57 AM
F15382050: D17369.id41767.diff
Mar 14 2025, 10:29 AM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable