Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F18832068: D17369.id.diff
Sat, Oct 25, 7:09 PM
F18826617: D17369.diff
Fri, Oct 24, 4:54 AM
F18759971: D17369.diff
Mon, Oct 6, 7:07 AM
F18753204: D17369.diff
Sat, Oct 4, 5:49 PM
F18653450: D17369.id.diff
Sep 21 2025, 1:35 PM
F18514446: D17369.id41766.diff
Sep 5 2025, 10:14 AM
F18508534: D17369.id.diff
Sep 5 2025, 2:52 AM
F18500602: D17369.diff
Sep 4 2025, 9:11 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable