Page MenuHomePhabricator

Fix a CalendarExport issue when an existing export has an unsupported mode
ClosedPublic

Authored by epriestley on Feb 16 2017, 2:20 PM.
Tags
None
Referenced Files
F18190528: D17369.id41767.diff
Sun, Aug 17, 12:55 AM
F18094362: D17369.id.diff
Thu, Aug 7, 10:06 PM
F17878397: D17369.id.diff
Mon, Jul 28, 8:17 PM
F17847574: D17369.diff
Sun, Jul 27, 6:18 AM
Unknown Object (File)
Jun 27 2025, 10:00 PM
Unknown Object (File)
Jun 27 2025, 6:26 PM
Unknown Object (File)
Jun 27 2025, 2:27 PM
Unknown Object (File)
Jun 16 2025, 10:26 PM
Subscribers
None

Details

Summary

See D16676. When an export has an unsupported mode (bad database value, out-of-date object, etc) the intent of this code is to put it into the <select /> so that you can save the form without silently changing the object.

However, it incorrectly calls array_shift() instead of array_unshift().

Test Plan

Edited a Calendar export with an invalid mode, saw the mode appear properly in the dropdown:

Screen Shot 2017-02-16 at 6.18.11 AM.png (382×440 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable