Differential D20148

In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 1:52 PM.

Tags

None

Referenced Files

	F15426300: D20148.id48124.diff
	Sun, Mar 23, 7:58 AM

	F15413153: D20148.diff
	Wed, Mar 19, 5:15 PM

	Unknown Object (File)
	Mon, Feb 24, 4:31 PM

	Unknown Object (File)
	Mon, Feb 24, 12:07 PM

	Unknown Object (File)
	Mon, Feb 24, 10:03 AM

	Unknown Object (File)
	Feb 17 2025, 1:20 AM

	Unknown Object (File)
	Jan 28 2025, 11:37 AM

	Unknown Object (File)
	Jan 26 2025, 7:51 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP00ffb190cc71: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"

Summary

See PHI1068. We currently show "HTTP Error - 200", which is misleading. Instead, label these results as "HTTP Status Code".

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2019, 1:52 PM

Harbormaster completed remote builds in B21951: Diff 48108.Feb 12 2019, 1:54 PM

epriestley requested review of this revision.Feb 12 2019, 1:54 PM

amckinley accepted this revision.Feb 12 2019, 7:09 PM

This revision is now accepted and ready to land.Feb 12 2019, 7:09 PM

Closed by commit rP00ffb190cc71: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error" (authored by epriestley). · Explain WhyFeb 12 2019, 10:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

storage/

HeraldWebhookRequest.php

2 lines

Diff 48124

View Options

src/applications/herald/storage/HeraldWebhookRequest.php

In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"ClosedPublicActions