HomePhabricator

[Wilds] Make "Bundle" test cases pass

Description

[Wilds] Make "Bundle" test cases pass

Summary:
Ref T13098. Continue to chip away at unit tests.

I stubbed out the read of configuration directly from RepositoryAPI and would like to remove it later. This is the only configuration value that RepositoryAPI reads directly. Instead, I suspect this will be cleaner if higher-level callers are responsible for reading and applying commit range rules and the actual RepositorAPI object does not know about them.

(In this particular case it's pretty moot anyway since unit tests shouldn't depend on .arcconfig settings.)

Test Plan: Ran unit tests, got slightly fewer failures.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13098

Differential Revision: https://secure.phabricator.com/D19713

Details

Provenance
epriestleyAuthored on Sep 27 2018, 5:39 PM
epriestleyPushed on Oct 1 2018, 11:35 PM
Reviewer
amckinley
Differential Revision
D19713: [Wilds] Make "Bundle" test cases pass
Parents
rARC964707ffdfa8: [Wilds] Make "Base Commit" parser test cases pass
Branches
Unknown
Tags
Unknown
Tasks
T13098: Plans: Arcanist toolsets and extensions
Build Status
Buildable 20938
Build 28458: Run Core Tests