Page MenuHomePhabricator

[Wilds] Make "Bundle" test cases pass
ClosedPublic

Authored by epriestley on Sep 27 2018, 5:41 PM.

Details

Summary

Ref T13098. Continue to chip away at unit tests.

I stubbed out the read of configuration directly from RepositoryAPI and would like to remove it later. This is the only configuration value that RepositoryAPI reads directly. Instead, I suspect this will be cleaner if higher-level callers are responsible for reading and applying commit range rules and the actual RepositorAPI object does not know about them.

(In this particular case it's pretty moot anyway since unit tests shouldn't depend on .arcconfig settings.)

Test Plan

Ran unit tests, got slightly fewer failures.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 27 2018, 5:41 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 27 2018, 5:41 PM
Harbormaster failed remote builds in B20916: Diff 47107!
epriestley requested review of this revision.Sep 27 2018, 5:43 PM
amckinley accepted this revision.Sep 27 2018, 8:19 PM
This revision is now accepted and ready to land.Sep 27 2018, 8:19 PM
This revision was automatically updated to reflect the committed changes.