HomePhabricator

Detect and correct "final private" methods in lint

Description

Detect and correct "final private" methods in lint

Summary:
Ref T13588. Marking a method "final private" has never been meaningful, and is an error in PHP8.

Add static analysis to detect (and correct) this issue.

Test Plan: Added unit tests, will lint "phabricator/".

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21539

Details

Provenance
epriestleyAuthored on Feb 3 2021, 9:46 PM
epriestleyPushed on Feb 3 2021, 10:14 PM
Differential Revision
D21539: Detect and correct "final private" methods in lint
Parents
rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols
Branches
Unknown
Tags
Unknown
Tasks
T13588: PHP 8 Compatibility
Build Status
Buildable 25088
Build 34618: Run Core Tests